tools docker #34
tools docker #34
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| docker build \ | ||
| --build-arg SISDK_Tag="$SISDK_Tag" \ | ||
| --build-arg WiFI_SDK_Tag="$WiFI_SDK_Tag" \ | ||
| -f docker/Dockerfile \ |
There was a problem hiding this comment.
Bug: Dockerfile Path Mismatch
The Dockerfile path -f docker/Dockerfile is incorrect. Based on the file structure, it should be -f docker/sdks/Dockerfile to reference the SDK-specific Dockerfile in the docker/sdks/ subdirectory.
| ln -s "$CONAN_PATH" "$INSTALL_PATH/conan" \ | ||
| else \ | ||
| echo "Error: conan not found at $CONAN_PATH" \ | ||
| fi \ |
There was a problem hiding this comment.
Bug: Missing dependency doesn't halt build.
When conan is not found at the expected path, the error message is printed but the script continues without exiting (missing exit 1), unlike the conan_engine check above. This inconsistency means the build continues even when conan installation fails.
.github/workflows/docker-publish.yml
Outdated
| if: ${{ github.event.inputs.tools == false }} | ||
| run: | | ||
| chmod +x docker/sdks/build.sh | ||
| ./docker/sdks/build.sh --tag "$VERSION" --push |
There was a problem hiding this comment.
Bug: Unintended Image Pushing
The build step always passes --push flag regardless of the push_images input value. The workflow defines a push_images input but never uses it, so images are always pushed even when push_images is false.
| ./docker/build.sh --tag "$VERSION" | ||
| fi | ||
| chmod +x docker/tools/build.sh | ||
| ./docker/tools/build.sh --tag "25Q4-Tools" --push |
There was a problem hiding this comment.
Bug: Push control ignored
The build step always passes --push flag regardless of the push_images input value. The workflow defines a push_images input but never uses it, so images are always pushed even when push_images is false.
| ./docker/build.sh --tag "$VERSION" | ||
| fi | ||
| chmod +x docker/tools/build.sh | ||
| ./docker/tools/build.sh --tag "25Q4-Tools" --push |
There was a problem hiding this comment.
Bug: Build Workflow Ignores Config, Incomplete Images.
The workflow unconditionally builds only the tools image with a hardcoded tag, ignoring both the push_images input parameter and the VERSION environment variable set in the previous step. This prevents building SDK images and makes the conditional version parsing logic unused.
| if [[ "${{ github.event.inputs.tools }}" == "false" ]]; then | ||
| ./docker/sdks/build.sh --tag "$VERSION" | ||
| else | ||
| ./docker/tools/build.sh --tag "$VERSION" |
There was a problem hiding this comment.
Bug: Fragile External Variable Dependency
The $VERSION variable is referenced but never defined in the script. The script expects this variable to be set in the environment, but there's no guarantee it will be available when the script runs.
| VERSION="SiSDK${SISDK_Tag}_WiFi_SDK${WiFI_SDK_Tag}" | ||
| echo "VERSION=$VERSION" >> $GITHUB_ENV | ||
| echo "Parsed VERSION: $VERSION" | ||
| fi |
There was a problem hiding this comment.
Bug: Version Mismatch: Hardcoded Tag Overrides Computation
The VERSION environment variable is set conditionally but never used. The subsequent build step at line 55 uses a hardcoded tag "25Q4-Tools" instead of the computed VERSION, making this entire step pointless and wasting CI resources parsing the version file.
| if [[ "${{ github.event.inputs.tools }}" == "false" ]]; then | ||
| ./docker/sdks/build.sh --tag "$VERSION" | ||
| else | ||
| ./docker/tools/build.sh --tag "$VERSION" |
There was a problem hiding this comment.
Bug: Incorrect Syntax and Undefined Variable Break Script
The script uses GitHub Actions template syntax ${{ github.event.inputs.tools }} which only works within GitHub Actions workflow files. When executed as a standalone shell script, this becomes a literal string that never equals "false", causing the else branch to always execute. Additionally, the VERSION variable is referenced but never defined, causing the script to pass an empty tag argument.
Note
Introduce a new tools Docker image and refactor build workflow/scripts to toggle between SDKs and tools builds with new inputs.
workflow_dispatchinputs:push_images(default true) andtools(default true).VERSIONwhen not building tools; upgrade checkout toactions/checkout@v5.docker/tools/build.shtagged25Q4-Tools.docker/build.shto delegate todocker/sdks/build.shordocker/tools/build.shbased ontoolsinput.docker/sdks/build.shto build/pushghcr.io/siliconlabssoftware/matter_extension_dependenciesusing parsed SDK tags.docker/tools/Dockerfileto install SLT, conan engine, SLC CLI, Commander, and ARM GCC.docker/tools/build.shanddocker/tools/requirements.txt.Written by Cursor Bugbot for commit a2446dc. This will update automatically on new commits. Configure here.